-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored LLM Integration #388
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asses still doesn't work
before pushing, make sure that this information about sk.json can be pushed!
… config.llm_service. When LLMService is needed again, just access the instance using LLMService() without having to supply the config.
…ritance (no more SAPLLM)
…was raised even though the use of llms was set to false This happened because the LLMService singleton was initialised even though it would not be needed later on. This happened because of an error in an if statement
fixes the environment variables iin the LLM tets and fixes sometest files unrelated to LLMss
…or assumes that LLM support is wanted. To not use LLM support, comment out the llm_service block in config.yaml
lauraschauer
force-pushed
the
lascha-llm-service
branch
from
June 24, 2024 09:59
d601453
to
0f8dd3d
Compare
lauraschauer
force-pushed
the
lascha-llm-service
branch
from
July 2, 2024 12:33
a1a5f72
to
53638d3
Compare
copernico
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the LLM integration. The most important changes are:
LLMService